Issue 159034: Change URLRequest to return net::ERR_INVALID_URL on redirects to invalid urls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159034: Change URLRequest to return net::ERR_INVALID_URL on redirects to invalid urls. (Closed)

Created:
11 years, 5 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Change URLRequest to return net::ERR_INVALID_URL on redirects to invalid urls. BUG=http://crbug.com/17126 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21234

Patch Set 2 : Address minor nits. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
A	net/data/url_request_unittest/redirect-to-invalid-url.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	net/data/url_request_unittest/redirect-to-invalid-url.html.mock-http-headers	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/url_request/url_request.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM! Sorry about the delay... http://codereview.chromium.org/159034/diff/1/3 File net/data/url_request_unittest/redirect-to-invalid-url.html.mock-http-headers (right): http://codereview.chromium.org/159034/diff/1/3#newcode1 Line 1: HTTP/1.1 302 Redirect ...

11 years, 5 months ago (2009-07-21 20:54:03 UTC) #2

willchan no longer on Chromium

11 years, 5 months ago (2009-07-21 23:06:38 UTC) #3

Waiting on tree to open.

http://codereview.chromium.org/159034/diff/1/3
File
net/data/url_request_unittest/redirect-to-invalid-url.html.mock-http-headers
(right):

http://codereview.chromium.org/159034/diff/1/3#newcode1
Line 1: HTTP/1.1 302 Redirect
On 2009/07/21 20:54:03, wtc wrote:
> Nit: Should the status text be "Found", according to RFC 2616?

Done.

http://codereview.chromium.org/159034/diff/1/4
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/159034/diff/1/4#newcode406
Line 406: return net::ERR_INVALID_URL;
On 2009/07/21 20:54:03, wtc wrote:
> I wonder if we should also add a DLOG(INFO) statement here.
> (I never look at those DLOG messages...)

I never read it, so I didn't bother adding it.

Expand Messages | Collapse Messages

Issue 159034: Change URLRequest to return net::ERR_INVALID_URL on redirects to invalid urls. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address minor nits. #

Messages