net/url_request/url_request.cc - Issue 159034: Change URLRequest to return net::ERR_INVALID_URL on redirects to invalid urls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request.cc

Issue 159034: Change URLRequest to return net::ERR_INVALID_URL on redirects to invalid urls. (Closed)

Patch Set: Address minor nits. Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request.cc

diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc

index b80ebe01d11b9b1a9629db61b3a9520942d3f8a8..7bccf6d63942f27c936b6c4537b39af9c2eef291 100644

--- a/net/url_request/url_request.cc

+++ b/net/url_request/url_request.cc

@@ -402,6 +402,9 @@ int URLRequest::Redirect(const GURL& location, int http_status_code) {

return net::ERR_TOO_MANY_REDIRECTS;

}

+ if (!location.is_valid())

+ return net::ERR_INVALID_URL;

if (!job_->IsSafeRedirect(location)) {

DLOG(INFO) << "disallowing redirect: unsafe protocol";

return net::ERR_UNSAFE_REDIRECT;