Merge autotest and autotest.py into one script

Darin proposed a way to run common.sh inside a python process and now I can get rid the bash wrapper around autotest.py.


The content of autotest.py is copied into autotest and I am leaving autotest.py inside the CL for now since its much easier to review the diff.

After got LGTM, I will git rm autotest.py and only submit autotest.

[petkov, 2010-04-05 17:46:39]

This LGTM although it doesn't quite work with the TOP_SCRIPT_DIR setting in
common.sh, however, TOP_SCRIPT_DIR should really be deleted along with its uses
in some old debian packaging related code.

[petkov, 2010-04-05 19:03:18]

On 2010/04/03 01:48:26, ericli wrote:
> 
One more comment: after this change, build_autotest.sh failures will not be as
obvious as they used to be because we'll miss the "die" call. It might be good
to put it back somehow...

[ericli, 2010-04-05 20:00:57]

PTAL.

the die function has been added into the python script.

I dont see I am using TOP_SCRIPT_DIR anywhere from my script, so I assume it is
harmless. Maybe I missed anything?


On 2010/04/05 19:03:18, petkov wrote:
> On 2010/04/03 01:48:26, ericli wrote:
> > 
> One more comment: after this change, build_autotest.sh failures will not be as
> obvious as they used to be because we'll miss the "die" call. It might be good
> to put it back somehow...

[petkov, 2010-04-05 20:21:55]

On 2010/04/05 20:00:57, ericli wrote:
> PTAL.
> 
> the die function has been added into the python script.
> 
> I dont see I am using TOP_SCRIPT_DIR anywhere from my script, so I assume it
is
> harmless. Maybe I missed anything?

Correct -- it's harmless because it's used only inside common.sh and only in old
debian packaging cruft that needs to go away.

> 
> 
> On 2010/04/05 19:03:18, petkov wrote:
> > On 2010/04/03 01:48:26, ericli wrote:
> > > 
> > One more comment: after this change, build_autotest.sh failures will not be
as
> > obvious as they used to be because we'll miss the "die" call. It might be
good
> > to put it back somehow...

[petkov, 2010-04-05 20:22:24]

http://codereview.chromium.org/1584013/diff/13001/11003
File src/scripts/autotest.py (right):

http://codereview.chromium.org/1584013/diff/13001/11003#newcode174
src/scripts/autotest.py:174: print >> sys.stderr, '\033[1;31mbuild_autotest
failed.\033[m'
Could you instead call something like '. common.sh && die blah...'? You could
define a "die" routine in this script that does that and use it elsewhere, if
necessary.

[ericli, 2010-04-05 20:50:52]

Done. Please take another look.

On 2010/04/05 20:22:24, petkov wrote:
> http://codereview.chromium.org/1584013/diff/13001/11003
> File src/scripts/autotest.py (right):
> 
> http://codereview.chromium.org/1584013/diff/13001/11003#newcode174
> src/scripts/autotest.py:174: print >> sys.stderr, '\033[1;31mbuild_autotest
> failed.\033[m'
> Could you instead call something like '. common.sh && die blah...'? You could
> define a "die" routine in this script that does that and use it elsewhere, if
> necessary.

[petkov, 2010-04-05 21:09:30]

You should probably do the sys.exit from the "die" routine (so it's a real die
routine). LGTM otherwise.

[ericli, 2010-04-05 21:26:56]

Done.
autotes.py  is removed from the CL and pushing... Thanks for reviewing this.

On Mon, Apr 5, 2010 at 2:09 PM, <petkov@chromium.org> wrote:

> You should probably do the sys.exit from the "die" routine (so it's a real
> die
> routine). LGTM otherwise.
>
>
>
> http://codereview.chromium.org/1584013
>



-- 
Eric Li
李咏竹
Google Kirkland