Issue 1573001: VBoot ReferenceL Add instructions to generate (self-)signed firmware images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1573001: VBoot ReferenceL Add instructions to generate (self-)signed firmware images. (Closed)

Created:
10 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, gauravsh

Visibility:
Public.

Description

VBoot ReferenceL Add instructions to generate (self-)signed firmware images.

Patch Set 2 : add note on -F4 #

Patch Set 3 : . #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -0 lines)			Patch
	M	src/platform/vboot_reference/README	View	1 2	1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

lgtm with nit http://codereview.chromium.org/1573001/diff/1/2 File src/platform/vboot_reference/README (right): http://codereview.chromium.org/1573001/diff/1/2#newcode80 src/platform/vboot_reference/README:80: $ utils/dumpRSAPublicKey signing_key.crt > signing_key.key should ...

10 years, 9 months ago (2010-03-29 19:47:24 UTC) #2

gauravsh

10 years, 9 months ago (2010-03-29 19:50:13 UTC) #3

On Mon, Mar 29, 2010 at 12:47 PM,  <cmasone@chromium.org> wrote:
> lgtm with nit
>
>
> http://codereview.chromium.org/1573001/diff/1/2
> File src/platform/vboot_reference/README (right):
>
> http://codereview.chromium.org/1573001/diff/1/2#newcode80
> src/platform/vboot_reference/README:80: $ utils/dumpRSAPublicKey
> signing_key.crt > signing_key.key
> should this be .keyb too?

Fixed and Submitted. Thanks!

>
> http://codereview.chromium.org/1573001
>



-- 
-g