Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1572012: Make mod_image_for_test work with default args (Closed)

Created:
10 years, 8 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
Bill Richardson, sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Make mod_image_for_test work with default args. Before the GPT change, by default mod_image_for_test would modify the result of your build.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/scripts/mod_image_for_test.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kmixter1
10 years, 8 months ago (2010-04-01 16:27:27 UTC) #1
sosa
lgtm
10 years, 8 months ago (2010-04-01 16:32:02 UTC) #2
Bill Richardson
LGTM
10 years, 8 months ago (2010-04-01 16:37:04 UTC) #3
kmixter1
10 years, 8 months ago (2010-04-01 17:09:22 UTC) #4
Thrice as nice!  Submitted.

On Thu, Apr 1, 2010 at 9:37 AM,  <wfrichar@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/1572012
>

Powered by Google App Engine
This is Rietveld 408576698