Clean up temporary files and directories left by build_image, etc.

Clean up temporary files and directories, add utilities.

Remove the temporary rootfs.image file and others that are left by build_image and related scripts. Also added tool to emit scripts that can pack and unpack the combined disk image.

[adlr, 2010-04-01 00:24:16]

http://codereview.chromium.org/1567013/diff/1/3
File src/scripts/build_image (right):

http://codereview.chromium.org/1567013/diff/1/3#newcode360
src/scripts/build_image:360: rm -f "${ROOT_FS_IMG}" "${STATEFUL_IMG}"
"${OUTPUT_DIR}/vmlinuz.image"
can you emit a shell script to extract the rootfs from the combined image?

It could be as simple as this:

--cut--
#!/bin/sh
dd if=chromiumos_image.bin of=rootfs.image bs=512
skip=FILLED_IN_BY_BUILD_PROCESS count=FILLED_IN_BY_BUILD_PROCESS
--cut--

[adlr, 2010-04-01 02:14:12]

LGTM w/ comments

http://codereview.chromium.org/1567013/diff/5001/6003
File src/scripts/emit_gpt_scripts.sh (right):

http://codereview.chromium.org/1567013/diff/5001/6003#newcode1
src/scripts/emit_gpt_scripts.sh:1: #!/bin/bash -x
take out -x

http://codereview.chromium.org/1567013/diff/5001/6003#newcode22
src/scripts/emit_gpt_scripts.sh:22: # We need to locate the gpt tool. It should
already be installed in the build
can you just include chromeos-common.sh to get this?

then you can just simplify this to making sure $GPT is set

http://codereview.chromium.org/1567013/diff/5001/6003#newcode42
src/scripts/emit_gpt_scripts.sh:42: # generated file. do not edit.
perhaps say, "File generated by emit_gpt_scripts.sh. Do not edit."

http://codereview.chromium.org/1567013/diff/5001/6003#newcode62
src/scripts/emit_gpt_scripts.sh:62: echo "sudo dd if=$file of=$loc bs=512
seek=$start count=$size conv=notrunc" \
80 cols

[kobic, 2010-04-01 17:12:12]

Just a quick comment about that change.

I personally used to like the idea that rootfs.image is still there and not
being removed. That way I could quickly add something to that rootfs.image (by
mounting it and emerge-<board> --usepkgonly --root-deps=rdeps
--root=/my/mounting/point) and re-run image_to_usb (or the build_gpt) to create
a full image for the team.

Now that the rootfs.image would be rm, is there another way to achieve the same
workflow? I don't want to re-run build_image for any little experiment change.

Let me know if my issue is unclear and I'll try to rephrase it.

Thx,
Kobi

[kobic, 2010-04-01 17:14:21]

> 
> Let me know if my issue is unclear and I'll try to rephrase it.

Just noticed Bill's posting on chromium os dev. There are scripts to extract the
images.
That's cool.

thx!
Kobi.

[Bill Richardson, 2010-04-01 17:26:45]

You can still mount the images directly. Look at the pack/unpack scripts to
see the location of the partition you want, multiply the start by 512 and
pass it as the offset to the loop mount command. For example, if I want to
mount rootfs, I'd do this:


blackadder$ ls
chromiumos_image.bin  pack_partitions.sh*  unpack_partitions.sh*
blackadder$ cat unpack_partitions.sh
#!/bin/sh -eu
# generated file. do not edit.
TARGET=${1:-}
if [[ -z "$TARGET" ]]; then
  echo "Usage: $0 DEVICE" 1>&2
  exit 1
fi
set -x
#     start     size  index  contents
#         0        1         PMBR (Boot GUID:
6b3c805c-4247-464d-9234-2cfa54d3d2a0)
#         1        1         Pri GPT header
#         2       32         Pri GPT table
#        34        6
#        40     5512      2  GPT part - "KERN-A" (ID:
f78add51-46d3-442f-9d78-c3df0c6110cc)
#      5552  1310720      1  GPT part - "STATE" (ID:
1b1a1cea-d3dc-4535-b629-2af06ac8077d)
#   1316272  1310720      3  GPT part - "ROOT-A" (ID:
6b3c805c-4247-464d-9234-2cfa54d3d2a0)
#   2626992       32         Sec GPT table
#   2627024        1         Sec GPT header
sudo dd if="$TARGET" of=part_1 bs=512 skip=5552 count=1310720
sudo dd if="$TARGET" of=part_2 bs=512 skip=40 count=5512
sudo dd if="$TARGET" of=part_3 bs=512 skip=1316272 count=1310720
blackadder$ mkdir rootfs
blackadder$ sudo mount -o loop,offset=$((1316272 * 512))
chromiumos_image.bin rootfs
blackadder$ ls rootfs/
bin/   build/  etc/   ibus.schemas  lost+found/  mnt/  postinst@  root/
 share/  tmp/  var/
boot/  dev/    home/  lib/          media/       opt/  proc/      sbin/
 sys/    usr/
blackadder$


Bill

On Thu, Apr 1, 2010 at 10:14 AM, <kobicaf@gmail.com> wrote:

>
>
>  Let me know if my issue is unclear and I'll try to rephrase it.
>>
>
> Just noticed Bill's posting on chromium os dev. There are scripts to
> extract the
> images.
> That's cool.
>
> thx!
>
> Kobi.
>
> http://codereview.chromium.org/1567013
>