chrome/browser/diagnostics/recon_diagnostics.cc - Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/recon_diagnostics.cc

Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations. (Closed)

Patch Set: comments Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/diagnostics/recon_diagnostics.cc

diff --git a/chrome/browser/diagnostics/recon_diagnostics.cc b/chrome/browser/diagnostics/recon_diagnostics.cc

index dc00bb616c70e4aff340a75e4ffcabf52739028c..c7afded313458ee2c060f0f46034f1c422c75b41 100644

--- a/chrome/browser/diagnostics/recon_diagnostics.cc

+++ b/chrome/browser/diagnostics/recon_diagnostics.cc

@@ -10,6 +10,7 @@

#include "base/utf_string_conversions.h"

#include "base/sys_info.h"

#include "base/path_service.h"

+#include "chrome/app/chrome_version_info.h"

#include "chrome/browser/diagnostics/diagnostics_test.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/platform_util.h"

@@ -108,7 +109,7 @@ class VersionTest : public DiagnosticTest {

virtual bool ExecuteImpl(DiagnosticsModel::Observer* observer) {

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForCurrentModule());

+ chrome_app::GetChromeVersionInfo());

if (!version_info.get()) {

RecordFailure(ASCIIToUTF16("No Version"));

return true;

« no previous file with comments | « chrome/browser/bug_report_util.cc ('k') | chrome/browser/extensions/extension_updater.cc » ('j') | no next file with comments »