chrome/browser/bug_report_util.cc - Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bug_report_util.cc

Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations. (Closed)

Patch Set: comments Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bug_report_util.cc

diff --git a/chrome/browser/bug_report_util.cc b/chrome/browser/bug_report_util.cc

index 1f8628e774cae2204d4a68f72a61ff38f67535b5..8426e3570abd933ece67b44b4a3e5d215c8dcb10 100644

--- a/chrome/browser/bug_report_util.cc

+++ b/chrome/browser/bug_report_util.cc

@@ -7,6 +7,7 @@

#include "app/l10n_util.h"

#include "base/file_version_info.h"

#include "base/utf_string_conversions.h"

+#include "chrome/app/chrome_version_info.h"

#include "chrome/browser/browser_process_impl.h"

#include "chrome/browser/net/url_fetcher.h"

#include "chrome/browser/profile.h"

@@ -144,7 +145,7 @@ void BugReportUtil::SendReport(Profile* profile,

std::string chrome_version;

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForCurrentModule());

+ chrome_app::GetChromeVersionInfo());

if (version_info.get()) {

chrome_version = WideToUTF8(version_info->product_name()) + " - " +

WideToUTF8(version_info->file_version()) +