Issue 1560003: Presubmit should now interpret "Closed" (upper case C) as meaning the tree is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1560003: Presubmit should now interpret "Closed" (upper case C) as meaning the tree is... (Closed)

Created:
10 years, 9 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, arv (Not doing code reviews), viettrungluu

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Presubmit should now interpret "Closed" (upper case C) as meaning the tree is closed. TEST=none at all BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43126

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	PRESUBMIT.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

http://codereview.chromium.org/1560003/diff/1/2 File PRESUBMIT.py (right): http://codereview.chromium.org/1560003/diff/1/2#newcode91 PRESUBMIT.py:91: '.*[Cc]losed.*')) I believe that '(?i).*closed.*' should just make it ...

10 years, 9 months ago (2010-03-29 23:20:59 UTC) #1

LGTM

Expand Messages | Collapse Messages

Issue 1560003: Presubmit should now interpret "Closed" (upper case C) as meaning the tree is... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages