Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: PRESUBMIT.py

Issue 1560003: Presubmit should now interpret "Closed" (upper case C) as meaning the tree is... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 ' Thanks for your patience.')) 81 ' Thanks for your patience.'))
82 results.extend(_CommonChecks(input_api, output_api)) 82 results.extend(_CommonChecks(input_api, output_api))
83 # TODO(thestig) temporarily disabled, doesn't work in third_party/ 83 # TODO(thestig) temporarily disabled, doesn't work in third_party/
84 #results.extend(input_api.canned_checks.CheckSvnModifiedDirectories( 84 #results.extend(input_api.canned_checks.CheckSvnModifiedDirectories(
85 # input_api, output_api, sources)) 85 # input_api, output_api, sources))
86 # Make sure the tree is 'open'. 86 # Make sure the tree is 'open'.
87 results.extend(input_api.canned_checks.CheckTreeIsOpen( 87 results.extend(input_api.canned_checks.CheckTreeIsOpen(
88 input_api, 88 input_api,
89 output_api, 89 output_api,
90 'http://chromium-status.appspot.com/current?format=raw', 90 'http://chromium-status.appspot.com/current?format=raw',
91 '.*closed.*')) 91 '(?i).*closed.*'))
92 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api, 92 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api,
93 output_api, 'http://codereview.chromium.org', ('win', 'linux', 'mac'), 93 output_api, 'http://codereview.chromium.org', ('win', 'linux', 'mac'),
94 'tryserver@chromium.org')) 94 'tryserver@chromium.org'))
95 95
96 # These builders are just too slow. 96 # These builders are just too slow.
97 IGNORED_BUILDERS = [ 97 IGNORED_BUILDERS = [
98 'Chromium XP', 98 'Chromium XP',
99 'Chromium Mac', 99 'Chromium Mac',
100 'Chromium Arm (dbg)', 100 'Chromium Arm (dbg)',
101 'Chromium Linux', 101 'Chromium Linux',
102 'Chromium Linux x64', 102 'Chromium Linux x64',
103 ] 103 ]
104 results.extend(input_api.canned_checks.CheckBuildbotPendingBuilds( 104 results.extend(input_api.canned_checks.CheckBuildbotPendingBuilds(
105 input_api, 105 input_api,
106 output_api, 106 output_api,
107 'http://build.chromium.org/buildbot/waterfall/json/builders?filter=1', 107 'http://build.chromium.org/buildbot/waterfall/json/builders?filter=1',
108 6, 108 6,
109 IGNORED_BUILDERS)) 109 IGNORED_BUILDERS))
110 return results 110 return results
111 111
112 112
113 def GetPreferredTrySlaves(): 113 def GetPreferredTrySlaves():
114 return ['win', 'linux', 'mac'] 114 return ['win', 'linux', 'mac']
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698