Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 155980: Fix a FORWARD_NULL defect reported by Coverity.... (Closed)

Created:
11 years, 5 months ago by wtc
Modified:
9 years ago
Reviewers:
CC:
chromium-reviews, Ben Goodger (Google)
Visibility:
Public.

Description

[Replaced by http://codereview.chromium.org/8827007 ] Fix a FORWARD_NULL defect reported by Coverity. We never construct a ScrollView object with a null horiz_sb_ or vert_sb_ member, and we already dereference horiz_sb_ and vert_sb_ without null checking in many places (including the destructor), so all the null checks for horiz_sb_ and vert_sb_ are unnecessary. R=ben BUG=http://crbug.com/17101 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M views/controls/scroll_view.cc View 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
11 years, 5 months ago (2009-07-23 02:33:15 UTC) #1
Ben Goodger (Google)
lgtm
9 years ago (2011-11-30 16:26:13 UTC) #2
wtc
9 years ago (2011-12-06 22:10:05 UTC) #3
I lost the source tree that has this CL, so I created a new
CL http://codereview.chromium.org/8827007 to check this change
in.

Powered by Google App Engine
This is Rietveld 408576698