Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 8827007: Fix a FORWARD_NULL defect reported by Coverity. (Closed)

Created:
9 years ago by wtc
Modified:
9 years ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix a FORWARD_NULL defect reported by Coverity. We never construct a ScrollView object with a null horiz_sb_ or vert_sb_ member, and we already dereference horiz_sb_ and vert_sb_ without null checking in many places (including the destructor), so all the null checks for horiz_sb_ and vert_sb_ are unnecessary. Original review URL: http://codereview.chromium.org/155980/ R=ben@chromium.org BUG=17101 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M ui/views/controls/scroll_view.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
lgtm
9 years ago (2011-12-06 22:12:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/8827007/1
9 years ago (2011-12-07 03:06:16 UTC) #2
commit-bot: I haz the power
9 years ago (2011-12-07 05:04:22 UTC) #3
Change committed as 113350

Powered by Google App Engine
This is Rietveld 408576698