Issue 155884: Fix issue where error pages inserted HTML from a template but the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155884: Fix issue where error pages inserted HTML from a template but the... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix issue where error pages inserted HTML from a template but the string from the template was used with JST instead of the i18n template and therefore it did not get recursively processed. Also make sure we can support recursive handling of setting innerHTML with the i18n template engine. BUG=17377 TEST=Navigate to http://ponderer.org/tests/redirect-loop.py The error page should show: The webpage at http://ponderer.org/tests/redirect-loop.py has ... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21240

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -18 lines)			Patch
	M	chrome/app/generated_resources.grd	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	chrome/browser/resources/i18n_template.js	View		2 chunks	+20 lines, -13 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM!