Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 155876: Revert r21117 as it caused reliability failures.... (Closed)

Created:
11 years, 5 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, jam, dank, the_wrong_timurrrr, stuartmorgan, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Revert r21117 as it caused reliability failures. Also included in this revert: r21165, r21180, and a couple valgrind suppression edits TBR=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -217 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/common/child_process.h View 2 chunks +11 lines, -17 lines 0 comments Download
M chrome/common/child_process.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/common/child_thread.h View 3 chunks +29 lines, -16 lines 0 comments Download
M chrome/common/child_thread.cc View 3 chunks +37 lines, -43 lines 0 comments Download
M chrome/common/histogram_synchronizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/ipc_channel_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/ipc_channel_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/plugin/plugin_thread.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/plugin/plugin_thread.cc View 6 chunks +41 lines, -15 lines 0 comments Download
M chrome/renderer/mock_render_process.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/render_process.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/render_process.cc View 4 chunks +36 lines, -15 lines 0 comments Download
M chrome/renderer/render_process_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.h View 3 chunks +16 lines, -5 lines 0 comments Download
M chrome/renderer/render_thread.cc View 7 chunks +63 lines, -36 lines 0 comments Download
M chrome/renderer/render_thread_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_main.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/utility/utility_main.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/utility/utility_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/utility/utility_thread.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/worker/worker_main.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/worker/worker_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/worker/worker_thread.cc View 1 chunk +22 lines, -7 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
huanr
11 years, 5 months ago (2009-07-21 21:09:28 UTC) #1 
LGTM

Powered by Google App Engine
This is Rietveld 408576698