Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/worker/worker_thread.cc

Issue 155876: Revert r21117 as it caused reliability failures.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/worker/worker_thread.h ('k') | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/worker/worker_thread.cc
===================================================================
--- chrome/worker/worker_thread.cc (revision 21215)
+++ chrome/worker/worker_thread.cc (working copy)
@@ -15,22 +15,37 @@
base::LINKER_INITIALIZED);
-WorkerThread::WorkerThread() {
+WorkerThread::WorkerThread()
+ : ChildThread(base::Thread::Options(MessageLoop::TYPE_DEFAULT,
+ kV8StackSize)) {
+}
+
+WorkerThread::~WorkerThread() {
+}
+
+WorkerThread* WorkerThread::current() {
+ return lazy_tls.Pointer()->Get();
+}
+
+void WorkerThread::Init() {
lazy_tls.Pointer()->Set(this);
+ ChildThread::Init();
webkit_client_.reset(new WorkerWebKitClientImpl);
WebKit::initialize(webkit_client_.get());
}
-WorkerThread::~WorkerThread() {
+void WorkerThread::CleanUp() {
// Shutdown in reverse of the initialization order.
- WebKit::shutdown();
+
+ if (webkit_client_.get()) {
+ WebKit::shutdown();
+ webkit_client_.reset();
+ }
+
+ ChildThread::CleanUp();
lazy_tls.Pointer()->Set(NULL);
}
-WorkerThread* WorkerThread::current() {
- return lazy_tls.Pointer()->Get();
-}
-
void WorkerThread::OnControlMessageReceived(const IPC::Message& msg) {
IPC_BEGIN_MESSAGE_MAP(WorkerThread, msg)
IPC_MESSAGE_HANDLER(WorkerProcessMsg_CreateWorker, OnCreateWorker)
« no previous file with comments | « chrome/worker/worker_thread.h ('k') | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698