Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 155836: Add a supression for a leak on Linux. I'm not really sure of the exact reaso... (Closed)

Created:
11 years, 5 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, stuartmorgan, the_wrong_timurrrr, Nirnimesh
Visibility:
Public.

Description

Update the callstack of a supressed leak since my recent code refactoring changed the callstack. TBR=dkegel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21181

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
11 years, 5 months ago (2009-07-21 03:31:57 UTC) #1
dank
LGTM. (No need to lengthen the stack, we usually leave main etc. off.)
11 years, 5 months ago (2009-07-21 03:46:57 UTC) #2
jam
ah, I didn't know that that it does partial matching. I'll remove main and ChromeMain ...
11 years, 5 months ago (2009-07-21 07:54:39 UTC) #3
dkegel
Did you check that in? On Tue, Jul 21, 2009 at 7:54 AM, John Abd-El-Malek<jam@chromium.org> ...
11 years, 5 months ago (2009-07-21 16:17:28 UTC) #4
jam
just did On Tue, Jul 21, 2009 at 9:16 AM, Dan Kegel <dkegel@google.com> wrote: > ...
11 years, 5 months ago (2009-07-21 16:46:06 UTC) #5
dkegel
11 years, 5 months ago (2009-07-21 21:06:11 UTC) #6
I understand estade is reverting the change and the suppression for you.
When you reland them, be sure to not include
fun:_Z12RendererMainRK18MainFunctionParams
or higher, as I think that made a unit test throw valgrind warnings today:
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(v=
algrind)/builds/1100/steps/valgrind%20test:%20unit/logs/stdio

On Tue, Jul 21, 2009 at 7:54 AM, John Abd-El-Malek<jam@chromium.org> wrote:
> ah, I didn't know that that it does partial matching. =A0 I'll remove mai=
n and
> ChromeMain in a followup.
>
> On Mon, Jul 20, 2009 at 8:46 PM, <dank@chromium.org> wrote:
>>
>> LGTM.
>> (No need to lengthen the stack, we usually leave main etc. off.)
>>
>>
>> http://codereview.chromium.org/155836
>
>

Powered by Google App Engine
This is Rietveld 408576698