Try again: Add proxy config (using gnome-network-preferences)

Try again: Add proxy config (using gnome-network-preferences)

BUG=11507
TEST=Open options, click change proxy, gnome-network-preferences should launch.  If gnome isn't installed or running, LinuxProxyConfig wiki page should load.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21246

[Evan Stade, 2009-07-21 20:40:41]

I think you will have to do something like in
http://codereview.chromium.org/159112 to make sure that the proxy settings
dialog has the right theme settings.

Also ensure zombie reaping a la
http://codereview.chromium.org/149057/diff/3001/4002

[mattm, 2009-07-21 21:56:20]

On 2009/07/21 20:40:41, Evan Stade wrote:
> I think you will have to do something like in
> http://codereview.chromium.org/159112 to make sure that the proxy settings
> dialog has the right theme settings.
> 
> Also ensure zombie reaping a la
> http://codereview.chromium.org/149057/diff/3001/4002

updated

[Evan Stade, 2009-07-21 22:01:25]

lgtm (nits)

http://codereview.chromium.org/155792/diff/10/14
File chrome/browser/gtk/options/advanced_contents_gtk.cc (right):

http://codereview.chromium.org/155792/diff/10/14#newcode310
Line 310: env.push_back(std::make_pair("GTK_PATH",
getenv("CHROMIUM_SAVED_GTK_PATH")));
80 chars

http://codereview.chromium.org/155792/diff/10/14#newcode322
Line 322: 
extra space here

[eroman, 2009-07-22 00:33:30]

http://codereview.chromium.org/155792/diff/23/1016
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/155792/diff/23/1016#newcode508
Line 508: // I (sdoyon) would have liked to prioritize environment variables
seems this comment should be moved into UseGnomeForSettings(), or removed.