Issue 159112: Set GTK_PATH to CHROMIUM_SAVED_GTK_PATH before launching xdg-open....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159112: Set GTK_PATH to CHROMIUM_SAVED_GTK_PATH before launching xdg-open.... (Closed)

Created:
11 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, brettw, Michael Moss

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set GTK_PATH to CHROMIUM_SAVED_GTK_PATH before launching xdg-open. Wrappers that launch Chromium will need to set CHROMIUM_SAVED_GTK_PATH before modifying GTK_PATH. This can be done later in separate CLs. BUG=15565 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21168

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Patch
M	base/process_util.h	View	1	2 chunks	+11 lines, -1 line	0 comments	Download
M	base/process_util_linux.cc	View		5 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/common/platform_util_linux.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

11 years, 5 months ago (2009-07-21 00:37:56 UTC) #2

LGTM

http://codereview.chromium.org/159112/diff/1/2
File base/process_util.h (right):

http://codereview.chromium.org/159112/diff/1/2#newcode148
Line 148: typedef std::vector<std::pair<const char*, char*> >
environment_vector;
Why isn't the second element of the pair const too?

Expand Messages | Collapse Messages