Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 155750: Add "Remove from list" for each download in domui page.... (Closed)

Created:
11 years, 5 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
Glen Murphy, brian
CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

Add "Remove from list" for each download in domui page. A "Remove from list" link would be added to the download items and once clicked, it will remove it from the shelf and list. BUG=60 (http://crbug.com/60) TEST=Download a file from the net, CTRL+J. Click on "Remove from list". The item removes from the list and download shelf. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22138

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/downloads_dom_handler.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/downloads_dom_handler.cc View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/downloads_ui.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/downloads.html View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mohamed Mansour
Glen please review the domui download additions. Glen and Brian, as well, the placement of ...
11 years, 5 months ago (2009-07-18 15:53:14 UTC) #1
Mohamed Mansour
ping
11 years, 5 months ago (2009-07-21 16:29:32 UTC) #2
Glen Murphy
Do you have a screenshot? On Tue, Jul 21, 2009 at 9:29 AM, <mhm@chromium.org> wrote: ...
11 years, 5 months ago (2009-07-21 16:53:08 UTC) #3
Mohamed Mansour
Glen: Here is the screenshot http://i32.tinypic.com/1z4iqh3.jpg
11 years, 5 months ago (2009-07-21 23:32:02 UTC) #4
Mohamed Mansour
ping
11 years, 5 months ago (2009-07-22 23:03:02 UTC) #5
Glen Murphy
http://codereview.chromium.org/155750/diff/14/1004 File chrome/browser/resources/downloads.html (right): http://codereview.chromium.org/155750/diff/14/1004#newcode625 Line 625: remove(this.id_); If you have two download windows open, ...
11 years, 5 months ago (2009-07-23 16:58:19 UTC) #6
Mohamed Mansour
Please review. Only one line removed from previous review. And it all works fine. http://codereview.chromium.org/155750/diff/14/1004 ...
11 years, 5 months ago (2009-07-24 23:48:18 UTC) #7
Mohamed Mansour
ping
11 years, 4 months ago (2009-07-27 15:22:52 UTC) #8
Mohamed Mansour
Any suggestions :) Only one line removed from previous review. And it all works fine!
11 years, 4 months ago (2009-07-29 20:50:24 UTC) #9
Glen Murphy
11 years, 4 months ago (2009-07-30 17:15:10 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld 408576698