Add "Remove from list" for each download in domui page....

Add "Remove from list" for each download in domui page.

A "Remove from list" link would be added to the download items and once clicked, it will remove it from the shelf and list.

BUG=60
(http://crbug.com/60)
TEST=Download a file from the net, CTRL+J. Click on "Remove from list".  The item removes from the list and download shelf.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22138

[Mohamed Mansour, 2009-07-18 15:53:14]

Glen please review the domui download additions. Glen and Brian, as well, the
placement of the "Remove from list" link.

Thanks!

[Mohamed Mansour, 2009-07-21 16:29:32]

ping

[Glen Murphy, 2009-07-21 16:53:08]

Do you have a screenshot?

On Tue, Jul 21, 2009 at 9:29 AM, <mhm@chromium.org> wrote:
> ping
>
> http://codereview.chromium.org/155750
>

[Mohamed Mansour, 2009-07-21 23:32:02]

Glen: Here is the screenshot 
http://i32.tinypic.com/1z4iqh3.jpg

[Mohamed Mansour, 2009-07-22 23:03:02]

ping

[Glen Murphy, 2009-07-23 16:58:19]

http://codereview.chromium.org/155750/diff/14/1004
File chrome/browser/resources/downloads.html (right):

http://codereview.chromium.org/155750/diff/14/1004#newcode625
Line 625: remove(this.id_);
If you have two download windows open, this isn't going to remove it from the
other one - I think you need to watch for remove messages in the DOMUI and use
that as the mechanism for removing the item, rather than removing it here.

[Mohamed Mansour, 2009-07-24 23:48:18]

Please review. Only one line removed from previous review. And it all works
fine.

http://codereview.chromium.org/155750/diff/14/1004
File chrome/browser/resources/downloads.html (right):

http://codereview.chromium.org/155750/diff/14/1004#newcode625
Line 625: remove(this.id_);
Actually, this is not needed anymore. The chrome.send("remove") will actually
inform all the download windows and actually remove the download item. I tested
that for different windows and tabs.

[Mohamed Mansour, 2009-07-27 15:22:52]

ping

[Mohamed Mansour, 2009-07-29 20:50:24]

Any suggestions :)
Only one line removed from previous review. And it all works fine!

[Glen Murphy, 2009-07-30 17:15:10]

LGTM