Add "Remove from list" for download item in the download shelf....

Add "Remove from list" for download item in the download shelf.

This would remove the download list (CTRL+J) as well.

BUG=60
(http://crbug.com/60)
TEST=Download a file from the net, download shelf appears, click the download item's arrow and "Remove from list". The item removes from the shelf and list.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22143

[Mohamed Mansour, 2009-07-18 15:11:37]

Evan for the Linux changes.
Scott for the context menu addition.
Brian for the UI.

[Evan Stade, 2009-07-19 07:16:39]

as a user of this feature it seems pretty unclear what it does. For example,
does it actually delete the download? And why does it remove it from the
history? I can see someone wanting it to just remove from the shelf. 

from a technical standpoint these changes lgtm (though don't you need to add a
new string resource?). I don't know the state of the mac shelf, is it not yet
functional?

[Mohamed Mansour, 2009-07-19 13:06:09]

Ah, I should have stated Brian's comment on the issue tracker:

"To further clarify on comment 29, this menu item would merely remove the item
from the download shelf and the downloads list in Chrome. To make it clear that
this does not delete from the user's disk, the menu item should be called
"Remove from list". The downloads page (ctrl+d) should have the same function
with the same name."

And sorry, I meant "download list" not history. Editing the description
appropriately.

[Evan Stade, 2009-07-20 17:47:17]

I guess I still think "remove from list" is ambiguous, and in the case of the
download shelf mystifying (as it has no list). For my money "remove record of
download" or "clear download from history" is better.

[Mohamed Mansour, 2009-07-20 18:17:29]

Brian: ping, estade has valid points. Your thoughts?

[Mohamed Mansour, 2009-07-21 23:31:20]

Here is a screenshot, would like to commit this before my source gets old ...

[Mohamed Mansour, 2009-07-21 23:31:45]

And the screenshot ...
http://i32.tinypic.com/1z4iqh3.jpg

[sky, 2009-07-30 16:25:50]

Did you run this by Glen/Ben?

  -Scott

On 2009/07/21 23:31:45, Mohamed Mansour wrote:
> And the screenshot ...
> http://i32.tinypic.com/1z4iqh3.jpg

[Ben Goodger (Google), 2009-07-30 16:39:20]

y

On Thu, Jul 30, 2009 at 9:25 AM, <sky@chromium.org> wrote:
>
> Did you run this by Glen/Ben?
>
> =A0-Scott
>
> On 2009/07/21 23:31:45, Mohamed Mansour wrote:
>>
>> And the screenshot ...
>> http://i32.tinypic.com/1z4iqh3.jpg
>
>
>
> http://codereview.chromium.org/155749
>

[Mohamed Mansour, 2009-07-30 18:46:05]

I thought Ben, Glen, Nick, and Brian are in the UI Team. Since Nick "OK'd" it in
the bug tracker as stated in my second comment here. That is why I did this
patch. Which works as expected.

[sky, 2009-07-30 20:21:50]

LGTM