Changes the width of pinned tabs to be slightly bigger.

Changes the width of pinned tabs to be slightly bigger.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20985

[James Hawkins, 2009-07-17 18:51:40]

lgtm

http://codereview.chromium.org/155701/diff/1/2
File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/155701/diff/1/2#newcode355
Line 355: pinned_tab_pref_width_ = 56;
nit: Can you make this a constant?

[sky, 2009-07-17 19:09:37]

Certainly. This changed around the patch a bit though, so you should
take another look.

Thanks,

  -Scott

On Fri, Jul 17, 2009 at 11:51 AM, <jhawkins@chromium.org> wrote:
> lgtm
>
>
> http://codereview.chromium.org/155701/diff/1/2
> File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):
>
> http://codereview.chromium.org/155701/diff/1/2#newcode355
> Line 355: pinned_tab_pref_width_ = 56;
> nit: Can you make this a constant?
>
> http://codereview.chromium.org/155701
>

[James Hawkins, 2009-07-17 19:11:50]

http://codereview.chromium.org/155701/diff/1002/7
File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/155701/diff/1002/7#newcode39
Line 39: static int kPinnedTabRendererAsTabWidth = kPinnedTabWidth + 30;
nit: don't need the static as it's in an anonymous namespace.  Make it const?

[sky, 2009-07-17 19:14:45]

Sorry about that. Done.

  -Scott

On Fri, Jul 17, 2009 at 12:11 PM, <jhawkins@chromium.org> wrote:
>
> http://codereview.chromium.org/155701/diff/1002/7
> File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):
>
> http://codereview.chromium.org/155701/diff/1002/7#newcode39
> Line 39: static int kPinnedTabRendererAsTabWidth =3D kPinnedTabWidth + 30=
;
> nit: don't need the static as it's in an anonymous namespace. =A0Make it
> const?
>
> http://codereview.chromium.org/155701
>

[James Hawkins, 2009-07-17 19:15:36]

lgtm