Issue 155700: Reverting 20516.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155700: Reverting 20516. (Closed)

Created:
11 years, 5 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting 20516 by re-landing this previous patch. Keep the cairo clipping region in sync with the Skia one. The PlatformCanvas now tracks this, so we don't need to have the similar code in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the cairo_t has a transform and clip but the surface does not. Review URL: http://codereview.chromium.org/149409 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20992

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -68 lines)			Patch
M	app/gfx/canvas_linux.cc	View	2 chunks	+1 line, -20 lines	0 comments	Download
M	base/gfx/native_widget_types.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_proxy.cc	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_linux.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_linux.cc	View	4 chunks	+109 lines, -10 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_win.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	skia/ext/canvas_paint_linux.h	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	skia/ext/platform_canvas_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/platform_device_linux.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_gtk.cc	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	webkit/tools/test_shell/webwidget_host_gtk.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages