Issue 149409: Keep the cairo clipping region in sync with the Skia one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149409: Keep the cairo clipping region in sync with the Skia one. (Closed)

Created:
11 years, 5 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Antoine Labour, sky, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Keep the cairo clipping region in sync with the Skia one. The PlatformCanvas now tracks this, so we don't need to have the similar code in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the cairo_t has a transform and clip but the surface does not. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20499

Patch Set 1 #

Total comments: 1

Patch Set 2 : git try #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -66 lines)			Patch
M	app/gfx/canvas_linux.cc	View	2 chunks	+1 line, -20 lines	0 comments	Download
M	base/gfx/native_widget_types.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_proxy.cc	View	2 chunks	+5 lines, -12 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_linux.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_linux.cc	View	5 chunks	+109 lines, -10 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_win.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	skia/ext/canvas_paint_linux.h	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	skia/ext/platform_canvas_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/platform_device_linux.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_gtk.cc	View	4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM with the following change. http://codereview.chromium.org/149409/diff/1/5 File skia/ext/bitmap_platform_device_linux.h (right): http://codereview.chromium.org/149409/diff/1/5#newcode90 Line 90: // Loads the ...

11 years, 5 months ago (2009-07-09 21:00:54 UTC) #2

Evan Martin

11 years, 5 months ago (2009-07-13 19:20:59 UTC) #3

I'd appreciate it if you CC'd me and piman on changes to plugin code.  This
seems to have regressed plugins, since the cairo_t* returned by
beginPlatformPaint() appears to be owned by the surface and shouldn't be freed
(the old code created the cairo and correctly freed it)

Expand Messages | Collapse Messages