Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 155608: Adding callback support to media filter Initialize() and Seek(). (Closed)

Created:
11 years, 5 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adding callback support to media filter Initialize() and Seek(). Also includes unit tests for AudioRendererBase and VideoRendererBase. I had to rollback my first attempt at this change. Original review: http://codereview.chromium.org/155469 BUG=16014, 16031 TEST=media_unittests, layout tests

Patch Set 1 #

Patch Set 2 : Full patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+746 lines, -185 lines) Patch
M chrome/renderer/media/buffered_data_source.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/renderer/media/buffered_data_source.cc View 4 chunks +23 lines, -13 lines 0 comments Download
M media/base/filter_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/filter_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/filter_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/filters.h View 8 chunks +29 lines, -15 lines 0 comments Download
M media/base/mock_filters.h View 8 chunks +80 lines, -17 lines 0 comments Download
A media/base/mock_filters.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M media/base/pipeline_impl.h View 2 chunks +4 lines, -5 lines 0 comments Download
M media/base/pipeline_impl.cc View 5 chunks +19 lines, -15 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 8 chunks +37 lines, -34 lines 0 comments Download
M media/filters/audio_renderer_base.h View 2 chunks +5 lines, -2 lines 0 comments Download
M media/filters/audio_renderer_base.cc View 4 chunks +12 lines, -4 lines 0 comments Download
A media/filters/audio_renderer_base_unittest.cc View 1 chunk +135 lines, -0 lines 0 comments Download
M media/filters/decoder_base.h View 3 chunks +17 lines, -8 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 6 chunks +18 lines, -8 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 9 chunks +23 lines, -7 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 6 chunks +16 lines, -6 lines 0 comments Download
media/filters/file_data_source.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/file_data_source.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M media/filters/file_data_source_unittest.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M media/filters/video_renderer_base.h View 3 chunks +6 lines, -2 lines 0 comments Download
M media/filters/video_renderer_base.cc View 5 chunks +30 lines, -14 lines 0 comments Download
A media/filters/video_renderer_base_unittest.cc View 1 chunk +215 lines, -0 lines 0 comments Download
M media/media.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/glue/media/simple_data_source.h View 2 chunks +5 lines, -1 line 0 comments Download
M webkit/glue/media/simple_data_source.cc View 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
This is the same as the earlier change http://codereview.chromium.org/155469 The next files you need to ...
11 years, 5 months ago (2009-07-15 23:57:05 UTC) #1
Alpha Left Google
11 years, 5 months ago (2009-07-16 00:00:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698