Splitting media filter's Initialize() into Create() + callback and Seek() + callback.

Splitting media filter's Initialize() into Create() + callback and Seek() + callback.

BUG=16014, 16031
TEST=media_unittests, layout tests

[Alpha Left Google, 2009-07-14 19:53:33]

Seems like this initialization callback breaks prerolling.

http://codereview.chromium.org/155469/diff/4/1011
File media/filters/audio_renderer_base.cc (right):

http://codereview.chromium.org/155469/diff/4/1011#newcode53
Line 53: }
there will be a leak if you don't delete |callback|/

http://codereview.chromium.org/155469/diff/4/1011#newcode67
Line 67: if (!OnInitialize(decoder_->media_format())) {
you need to save |callback|.

http://codereview.chromium.org/155469/diff/4/1011#newcode98
Line 98: //host()->InitializationComplete();
and the callback is invoke here.

http://codereview.chromium.org/155469/diff/4/1021
File media/filters/video_renderer_base.cc (right):

http://codereview.chromium.org/155469/diff/4/1021#newcode97
Line 97: FilterCallback* callback) {
Again, the async initialization breaks prerolling..

[scherkus (not reviewing), 2009-07-14 23:33:06]

Fixed alpha's comments and wrote unit tests to verify the failures.

http://codereview.chromium.org/155469/diff/4/1011
File media/filters/audio_renderer_base.cc (right):

http://codereview.chromium.org/155469/diff/4/1011#newcode53
Line 53: }
On 2009/07/14 19:53:33, Alpha wrote:
> there will be a leak if you don't delete |callback|/

Done.

http://codereview.chromium.org/155469/diff/4/1011#newcode67
Line 67: if (!OnInitialize(decoder_->media_format())) {
On 2009/07/14 19:53:33, Alpha wrote:
> you need to save |callback|.

Done.

http://codereview.chromium.org/155469/diff/4/1011#newcode98
Line 98: //host()->InitializationComplete();
On 2009/07/14 19:53:33, Alpha wrote:
> and the callback is invoke here.

haha this is why we should have unit tests :P

nice catches :)

http://codereview.chromium.org/155469/diff/4/1021
File media/filters/video_renderer_base.cc (right):

http://codereview.chromium.org/155469/diff/4/1021#newcode97
Line 97: FilterCallback* callback) {
On 2009/07/14 19:53:33, Alpha wrote:
> Again, the async initialization breaks prerolling..

yeah we don't have unit tests written for the renderer base classes, so I
completely missed these

[Alpha Left Google, 2009-07-14 23:37:53]

LGTM