Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 155548: Merge 20436 - Fix a crash that happens if a tab is closed while... (Closed)

Created:
11 years, 5 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
tony, tc
CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 20436 - Fix a crash that happens if a tab is closed while we're in the middle of a drag originating from the tab. The problem is that the tab gets deleted out from under the drag operation which is happening in a nested message loop. To work around this, if we're in the middle of a drag and we get a tab close request, delay the tab close until after the drag operation is finished. BUG=16280 Review URL: http://codereview.chromium.org/149466 TBR=tc@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -10 lines) Patch
MM base/base_drag_source.h View 2 chunks +10 lines, -0 lines 0 comments Download
MM base/base_drag_source.cc View 2 chunks +4 lines, -1 line 0 comments Download
MM chrome/browser/tab_contents/tab_contents.cc View 1 chunk +7 lines, -0 lines 0 comments Download
MM chrome/browser/tab_contents/tab_contents_view.h View 1 chunk +8 lines, -0 lines 0 comments Download
MM chrome/browser/tab_contents/web_drag_source.cc View 1 chunk +0 lines, -5 lines 0 comments Download
MM chrome/browser/views/tab_contents/tab_contents_view_win.h View 4 chunks +19 lines, -0 lines 0 comments Download
MM chrome/browser/views/tab_contents/tab_contents_view_win.cc View 7 chunks +31 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 5 months ago (2009-07-15 00:49:33 UTC) #1
tony
11 years, 5 months ago (2009-07-15 01:25:11 UTC) #2
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698