Fix a crash that happens if a tab is closed while

Fix a crash that happens if a tab is closed while
we're in the middle of a drag originating from the tab.

The problem is that the tab gets deleted out from under the
drag operation which is happening in a nested message loop.

To work around this, if we're in the middle of a drag and
we get a tab close request, delay the tab close until after
the drag operation is finished.

BUG=16280

[darin (slow to review), 2009-07-10 20:58:27]

LGTM

http://codereview.chromium.org/149466/diff/1/7
File chrome/browser/views/tab_contents/tab_contents_view_win.cc (right):

http://codereview.chromium.org/149466/diff/1/7#newcode52
Line 52: view_->CloseTab();
Are you certain that view_ will not be deleted before CloseTabTask runs?

To be safe, you might want to use ScopedRunnableMethodFactory or
base::OneShotTimer.

[tony, 2009-07-10 21:17:19]

http://codereview.chromium.org/149466/diff/1/7
File chrome/browser/views/tab_contents/tab_contents_view_win.cc (right):

http://codereview.chromium.org/149466/diff/1/7#newcode52
Line 52: view_->CloseTab();
On 2009/07/10 20:58:27, darin wrote:
> Are you certain that view_ will not be deleted before CloseTabTask runs?
> 
> To be safe, you might want to use ScopedRunnableMethodFactory or
> base::OneShotTimer.

I tried to use a NewRunnableMethod, but that requires TabContentsView to be ref
counted (currently it's just a scoped_ptr that tab_contents owns).  I'm a bit
nervous about changing TabContentsView to be ref counted.

I think this is safe because this code should prevent the view from being
deleted during the d&d operation.  This leaves the time between the end of the
d&d operation and ClostTabTask being queued, but this happens immediately.

[darin (slow to review), 2009-07-10 21:35:43]

http://codereview.chromium.org/149466/diff/1/7
File chrome/browser/views/tab_contents/tab_contents_view_win.cc (right):

http://codereview.chromium.org/149466/diff/1/7#newcode52
Line 52: view_->CloseTab();
Neither of my suggestions require changing TabContentsView to be ref counted.

OneShotTimer is the easiest to use.  ScopedRunnableMethodFactory should be used
if you need multiple "runnable methods" in flight at once.

[tony, 2009-07-10 21:53:37]

On 2009/07/10 21:35:43, darin wrote:
> http://codereview.chromium.org/149466/diff/1/7
> File chrome/browser/views/tab_contents/tab_contents_view_win.cc (right):
> 
> http://codereview.chromium.org/149466/diff/1/7#newcode52
> Line 52: view_->CloseTab();
> Neither of my suggestions require changing TabContentsView to be ref counted.
> 
> OneShotTimer is the easiest to use.  ScopedRunnableMethodFactory should be
used
> if you need multiple "runnable methods" in flight at once.

Aha!  Patch set 2 users a OneShotTimer.  Less code too!

[darin (slow to review), 2009-07-10 21:58:38]

LGTM