Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 155537: [Mac] Remove guard on FocusLocation() in autocomplete field. (Closed)

Created:
11 years, 5 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[Mac] Remove guard on FocusLocation() in autocomplete field. Reapplies http://codereview.chromium.org/149492 . That version was accidentally calling this code as part of the class implementation, which caused the code to receive the "done editing" notification, which caused the code to drop the popup... This version stops using FocusLocation() internally, instead messaging field_ directly. http://crbug.com/12246 TEST=Type some stuff in address bar. Popup should popup with suggestions. With cursor still in bar, Command-l should select all.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 3 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
I think the other change I proposed would have worked, but this one I'm pretty ...
11 years, 5 months ago (2009-07-14 22:16:51 UTC) #1
Avi (use Gerrit)
11 years, 5 months ago (2009-07-15 14:20:27 UTC) #2
LG

Powered by Google App Engine
This is Rietveld 408576698