Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: media/filters/video_renderer_base.h

Issue 155469: Splitting media filter's Initialize() into Create() + callback and Seek() + callback. (Closed)
Patch Set: Fixed valgrind errors Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/file_data_source_unittest.cc ('k') | media/filters/video_renderer_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_renderer_base.h
diff --git a/media/filters/video_renderer_base.h b/media/filters/video_renderer_base.h
index e71befa96a0cb5b89be53c97dc48e6f59b252440..b1b46abcd56b953617b5dc7a09de2e1dead398b3 100644
--- a/media/filters/video_renderer_base.h
+++ b/media/filters/video_renderer_base.h
@@ -39,10 +39,10 @@ class VideoRendererBase : public VideoRenderer,
// MediaFilter implementation.
virtual void Stop();
virtual void SetPlaybackRate(float playback_rate);
- virtual void Seek(base::TimeDelta time);
+ virtual void Seek(base::TimeDelta time, FilterCallback* callback);
// VideoRenderer implementation.
- virtual bool Initialize(VideoDecoder* decoder);
+ virtual void Initialize(VideoDecoder* decoder, FilterCallback* callback);
// PlatformThread::Delegate implementation.
virtual void ThreadMain();
@@ -106,6 +106,7 @@ class VideoRendererBase : public VideoRenderer,
INITIALIZING,
INITIALIZED,
STOPPED,
+ ERRORED,
};
State state_;
@@ -117,6 +118,9 @@ class VideoRendererBase : public VideoRenderer,
float playback_rate_;
+ // Filter callbacks.
+ scoped_ptr<FilterCallback> initialize_callback_;
+
DISALLOW_COPY_AND_ASSIGN(VideoRendererBase);
};
« no previous file with comments | « media/filters/file_data_source_unittest.cc ('k') | media/filters/video_renderer_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698