Issue 155354: Enforce presubmit check of try run. Add a nice message to give feedback to th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155354: Enforce presubmit check of try run. Add a nice message to give feedback to th... (Closed)

Created:
11 years, 5 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Enforce presubmit check of try run. Add a nice message to give feedback to the right person. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20397

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	PRESUBMIT.py	View	1 2	1 chunk	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

It works (albeit with a slight string error): 12:28:31,32 d:\code\chrome\n4\src\gcl commit presubmit ** Presubmit Warnings ...

11 years, 5 months ago (2009-07-10 16:29:28 UTC) #2

Nicolas Sylvain

11 years, 5 months ago (2009-07-10 16:44:08 UTC) #3

am i seeing the right code? I don't see where you actually enforce it

http://codereview.chromium.org/155354/diff/1003/1004
File PRESUBMIT.py (right):

http://codereview.chromium.org/155354/diff/1003/1004#newcode97
Line 97: 'Do you think the try server is wrong or broken? Please notify '
can be only: "Try server wrong or broken? Notify maruel@chromium.org"

Expand Messages | Collapse Messages