Enforce presubmit check of try run. Add a nice message to give feedback to th...

PRESUBMIT.py

 #!/usr/bin/python
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into gcl.
 """
@@ skipping 64 matching lines @@
   if not input_api.change.issue or not input_api.change.patchset:
     return outputs
   url = "http://codereview.chromium.org/%d/get_build_results/%d" % (
             input_api.change.issue, input_api.change.patchset)
   try:
     connection = input_api.urllib2.urlopen(url)
     # platform|status|url
     values = [item.split('|', 2) for item in connection.read().splitlines()]
     connection.close()
     statuses = map(lambda x: x[1], values)
+    message = None
     if 'failure' in statuses:
       failures = filter(lambda x: x[1] != 'success', values)
       long_text = '\n'.join("% 5s: % 7s %s" % (item[0], item[1], item[2])
                             for item in failures)
-      # TODO(maruel): Change to a PresubmitPromptWarning once the try server is
-      # stable enough and it seems to work fine.
-      message = 'You had try job failures. Are you sure you want to check-in?'
-      outputs.append(output_api.PresubmitNotifyResult(message=message,
-                                                      long_text=long_text))
+      message = 'You had try job failures. Are you sure you want to check-in?\n'
     elif 'pending' in statuses or len(values) != 3:
       long_text = '\n'.join("% 5s: % 7s %s" % (item[0], item[1], item[2])
                             for item in values)
-      # TODO(maruel): Change to a PresubmitPromptWarning once the try server is
-      # stable enough and it seems to work fine.
-      message = 'You should try the patch first (and wait for it to finish).'
-      outputs.append(output_api.PresubmitNotifyResult(message=message,
-                                                      long_text=long_text))
+      message = 'You should try the patch first (and wait for it to finish).\n'
+    if message:
+      message += (
+          'Is try server wrong or broken? Please notify maruel@chromium.org. '
+          'Thanks.\n')
+      outputs.append(output_api.PresubmitPromptWarning(message=message,
+                                                       long_text=long_text))
   except input_api.urllib2.HTTPError, e:
     if e.code == 404:
       # Fallback to no try job.
       # TODO(maruel): Change to a PresubmitPromptWarning once the try server is
       # stable enough and it seems to work fine.
       outputs.append(output_api.PresubmitNotifyResult(
           'You should try the patch first.'))
     else:
       # Another HTTP error happened, warn the user.
       # TODO(maruel): Change to a PresubmitPromptWarning once it deemed to work
@@ skipping 22 matching lines @@
                                     text)
         if match:
           long_text = match.group(1).strip()
       except IOError:
         pass
       return [output_api.PresubmitPromptWarning("The tree is closed.",
                                                 long_text=long_text)]
   except IOError:
     pass
   return []