Make sure we end up with an executable binary when juggling stripped binaries...

Make sure we end up with an executable binary when juggling stripped binaries and fake dSYMs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20305

[Mark Mentovai, 2009-07-09 19:54:31]

LGTM as-is, but I'd prefer copymode unless you have a reason to not do it.

("The mode might be wrong on saved_test_command too" is not a reason.)

http://codereview.chromium.org/155305/diff/1/2
File tools/valgrind/valgrind_test.py (right):

http://codereview.chromium.org/155305/diff/1/2#newcode311
Line 311: os.chmod(test_command, 0755)
shutil.copymode(saved_test_command, test_command)

[TVL, 2009-07-09 19:57:55]

why not just use copy2 and get it all done in one shot?
TVL


On Thu, Jul 9, 2009 at 3:54 PM, <mark@chromium.org> wrote:

>
> LGTM as-is, but I'd prefer copymode unless you have a reason to not do
> it.
>
> ("The mode might be wrong on saved_test_command too" is not a reason.)
>
>
> http://codereview.chromium.org/155305/diff/1/2
> File tools/valgrind/valgrind_test.py (right):
>
> http://codereview.chromium.org/155305/diff/1/2#newcode311
> Line 311: os.chmod(test_command, 0755)
> shutil.copymode(saved_test_command, test_command)
>
>
> http://codereview.chromium.org/155305
>

[TVL, 2009-07-09 19:58:46]

On Thu, Jul 9, 2009 at 3:57 PM, Thomas Van Lenten <thomasvl@chromium.org>wrote:

> why not just use copy2 and get it all done in one shot?


actually, just copy since you just need permissions and now owners.

TVL


>
> TVL
>
>
> On Thu, Jul 9, 2009 at 3:54 PM, <mark@chromium.org> wrote:
>
>>
>> LGTM as-is, but I'd prefer copymode unless you have a reason to not do
>> it.
>>
>> ("The mode might be wrong on saved_test_command too" is not a reason.)
>>
>>
>> http://codereview.chromium.org/155305/diff/1/2
>> File tools/valgrind/valgrind_test.py (right):
>>
>> http://codereview.chromium.org/155305/diff/1/2#newcode311
>> Line 311: os.chmod(test_command, 0755)
>> shutil.copymode(saved_test_command, test_command)
>>
>>
>> http://codereview.chromium.org/155305
>>
>
>

[stuartmorgan, 2009-07-09 20:07:07]

http://codereview.chromium.org/155305/diff/1/2
File tools/valgrind/valgrind_test.py (right):

http://codereview.chromium.org/155305/diff/1/2#newcode311
Line 311: os.chmod(test_command, 0755)
On 2009/07/09 19:54:31, Mark Mentovai wrote:
> shutil.copymode(saved_test_command, test_command)

Done.

[Mark Mentovai, 2009-07-09 20:07:47]

lgtm