Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 155305: Make sure we end up with an executable binary when juggling stripped binaries... (Closed)

Created:
11 years, 5 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, stuartmorgan, dank, the_wrong_timurrrr, Nirnimesh
Visibility:
Public.

Description

Make sure we end up with an executable binary when juggling stripped binaries and fake dSYMs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20305

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/valgrind/valgrind_test.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
11 years, 5 months ago (2009-07-09 19:50:38 UTC) #1
Mark Mentovai
LGTM as-is, but I'd prefer copymode unless you have a reason to not do it. ...
11 years, 5 months ago (2009-07-09 19:54:31 UTC) #2
TVL
why not just use copy2 and get it all done in one shot? TVL On ...
11 years, 5 months ago (2009-07-09 19:57:55 UTC) #3
TVL
On Thu, Jul 9, 2009 at 3:57 PM, Thomas Van Lenten <thomasvl@chromium.org>wrote: > why not ...
11 years, 5 months ago (2009-07-09 19:58:46 UTC) #4
stuartmorgan
http://codereview.chromium.org/155305/diff/1/2 File tools/valgrind/valgrind_test.py (right): http://codereview.chromium.org/155305/diff/1/2#newcode311 Line 311: os.chmod(test_command, 0755) On 2009/07/09 19:54:31, Mark Mentovai wrote: ...
11 years, 5 months ago (2009-07-09 20:07:07 UTC) #5
Mark Mentovai
11 years, 5 months ago (2009-07-09 20:07:47 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698