Issue 155252: Remove errant semicolon. distcc's pump mode didn't understand this.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155252: Remove errant semicolon. distcc's pump mode didn't understand this. (Closed)

Created:
11 years, 5 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, jeremy

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Remove errant semicolon. distcc's pump mode didn't understand this. Also fix presubmit warnings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20208

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	chrome/browser/global_keyboard_shortcuts_mac.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/browser/global_keyboard_shortcuts_mac.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
MM	chrome/browser/global_keyboard_shortcuts_mac_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

TBR (this is causing distcc to revert from pump mode to ordinary slow mode)

11 years, 5 months ago (2009-07-08 23:40:43 UTC) #1

jeremy

11 years, 5 months ago (2009-07-09 04:25:19 UTC) #3

LGTM

On Thu, Jul 9, 2009 at 3:02 AM, <nsylvain@chromium.org> wrote:

> Funny! Good catch! LGTM
>
>
> http://codereview.chromium.org/155252
>