Linux: For mouse button clicks, only send buttons 1, 2, 3 to the renderer....

Linux: For mouse button clicks, only send buttons 1, 2, 3 to the renderer.

BUG=16236
TEST=no more sad tab on clicking mouse back button


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20217

[Evan Martin, 2009-07-09 00:01:08]

LGTM

http://codereview.chromium.org/155250/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/155250/diff/1/2#newcode257
Line 257: gtk_widget_grab_focus(widget);
I wonder if this bit of code is related to the mystery focus bugs we've had.

[Evan Stade, 2009-07-09 00:11:08]

http://codereview.chromium.org/155250/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/155250/diff/1/2#newcode257
Line 257: gtk_widget_grab_focus(widget);
On 2009/07/09 00:01:08, Evan Martin wrote:
> I wonder if this bit of code is related to the mystery focus bugs we've had.

I wouldn't be too surprised, it's worth messing around with.

[tony, 2009-07-09 18:42:07]

I'm getting some browser windows where I can't get a context menu in the web
contents area.  Doesn't happen on all windows.  Reverting this change locally
seems to fix it for me.  Maybe it's the return statement that's causing
problems?

On 2009/07/09 00:11:08, Evan Stade wrote:
> http://codereview.chromium.org/155250/diff/1/2
> File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (right):
> 
> http://codereview.chromium.org/155250/diff/1/2#newcode257
> Line 257: gtk_widget_grab_focus(widget);
> On 2009/07/09 00:01:08, Evan Martin wrote:
> > I wonder if this bit of code is related to the mystery focus bugs we've had.
> 
> I wouldn't be too surprised, it's worth messing around with.

[Evan Stade, 2009-07-09 20:14:30]

oh yea, now that you mention it... the tab contents view catches the
button press events to get the proper time for drags and context
menus. So if we return TRUE, we are stopping those from getting caught
(since the tab contents handler is installed after our handler). I
guess changing TRUE back to FALSE will solve it.

-- Evan Stade



On Thu, Jul 9, 2009 at 11:42 AM, <tony@chromium.org> wrote:
> I'm getting some browser windows where I can't get a context menu in the
> web contents area. =A0Doesn't happen on all windows. =A0Reverting this
> change locally seems to fix it for me. =A0Maybe it's the return statement
> that's causing problems?
>
> On 2009/07/09 00:11:08, Evan Stade wrote:
>>
>> http://codereview.chromium.org/155250/diff/1/2
>> File chrome/browser/renderer_host/render_widget_host_view_gtk.cc
>
> (right):
>
>> http://codereview.chromium.org/155250/diff/1/2#newcode257
>> Line 257: gtk_widget_grab_focus(widget);
>> On 2009/07/09 00:01:08, Evan Martin wrote:
>> > I wonder if this bit of code is related to the mystery focus bugs
>
> we've had.
>
>> I wouldn't be too surprised, it's worth messing around with.
>
>
>
> http://codereview.chromium.org/155250
>