Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 155190: Add a suppression for a leak the Mac UI tests get when plugins are first load... (Closed)

Created:
11 years, 5 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com, dank, Nirnimesh
Visibility:
Public.

Description

Add a suppression for a leak the Mac UI tests get when plugins are first loaded. BUG=none TEST=Fewer leaks on the Mac valgrind UI test bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/valgrind/suppressions_mac.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stuartmorgan
11 years, 5 months ago (2009-07-08 00:37:55 UTC) #1
dkegel
11 years, 5 months ago (2009-07-08 00:52:59 UTC) #2
LGTM
maybe link to some page that explains it a bit.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D39366 touches on
the same issue for linux... maybe that's close enough?

On Tue, Jul 7, 2009 at 5:37 PM, <stuartmorgan@chromium.org> wrote:
> Reviewers: dank,
>
> Description:
> Add a suppression for a leak the Mac UI tests get when plugins are first
> loaded.
>
> BUG=3Dnone
> TEST=3DFewer leaks on the Mac valgrind UI test bots
>
> Please review this at http://codereview.chromium.org/155190
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 tools/valgrind/suppressions_mac.txt
>
>
> Index: tools/valgrind/suppressions_mac.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- tools/valgrind/suppressions_mac.txt (revision 20101)
> +++ tools/valgrind/suppressions_mac.txt (working copy)
> @@ -292,3 +292,16 @@
> =A0 =A0fun:CGContextDrawImage
> =A0 =A0fun:_ZN3gfx17CGImageToSkBitmapEP7CGImage
> =A0}
> +
> +{
> + =A0 # Tiny one-time leak, widely seen by valgind users; everyone suppre=
sses
> this.
> + =A0 plugin_bundle_global_leak
> + =A0 Memcheck:Leak
> + =A0 fun:malloc
> + =A0 fun:__cxa_get_globals
> + =A0 fun:__cxa_allocate_exception
> + =A0 fun:_ZN4dyld4loadEPKcRKNS_11LoadContextE
> + =A0 fun:dlopen
> + =A0 fun:dlopen
> + =A0 fun:_CFBundleDlfcnCheckLoaded
> +}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698