Issue 155174: linux: fix renderer/plugin crash when loading multiple pages with plugins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155174: linux: fix renderer/plugin crash when loading multiple pages with plugins (Closed)

Created:
11 years, 5 months ago by Antoine Labour

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: fix renderer/plugin crash when loading multiple pages with plugins Currently we crash if one renderer has a plugin and another one has a plugin that gets destroyed, and started again (e.g. reload). We get away with reload on a single page currently because the process gets torn down. This properly cleans up the socket and channel mapping on both sides, so it can be restarted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20112

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -7 lines)			Patch
M	chrome/common/ipc_channel_posix.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/ipc_channel_posix.cc	View	4 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/plugin/plugin_channel.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/plugin_channel_host.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

(do you have commit access yet?)

Expand Messages | Collapse Messages