chrome/plugin/plugin_channel.cc - Issue 155174: linux: fix renderer/plugin crash when loading multiple pages with plugins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/plugin/plugin_channel.cc

Issue 155174: linux: fix renderer/plugin crash when loading multiple pages with plugins (Closed)

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/plugin/plugin_channel.cc

diff --git a/chrome/plugin/plugin_channel.cc b/chrome/plugin/plugin_channel.cc

index 6264af52a7bf7385d0161b03c1c201c6147d6289..7977218214abfded2e81f01e7a196c8f4f55923e 100644

--- a/chrome/plugin/plugin_channel.cc

+++ b/chrome/plugin/plugin_channel.cc

@@ -48,7 +48,8 @@ PluginChannel::~PluginChannel() {

if (renderer_handle_)

base::CloseProcessHandle(renderer_handle_);

#if defined(OS_POSIX)

- // If we still have the FD, close it.

+ IPC::RemoveAndCloseChannelSocket(channel_name());

+ // If we still have the renderer FD, close it.

if (renderer_fd_ != -1) {

close(renderer_fd_);

}

« no previous file with comments | « chrome/common/ipc_channel_posix.cc ('k') | chrome/renderer/plugin_channel_host.cc » ('j') | no next file with comments »