net/socket/client_socket_handle.cc - Issue 155150: CHECK to make sure connection_group is never empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_handle.cc

Issue 155150: CHECK to make sure connection_group is never empty. (Closed)

Patch Set: Add comments. Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_handle.cc

diff --git a/net/socket/client_socket_handle.cc b/net/socket/client_socket_handle.cc

index 15f99a60673ad9222d4a3533d8f13d30c699f4a7..384d205e61fe7a248993c848a78919bceef39fa6 100644

--- a/net/socket/client_socket_handle.cc

+++ b/net/socket/client_socket_handle.cc

@@ -27,6 +27,7 @@ int ClientSocketHandle::Init(const std::string& group_name,

const HostResolver::RequestInfo& resolve_info,

int priority,

CompletionCallback* callback) {

+ CHECK(!group_name.empty());

ResetInternal(true);

group_name_ = group_name;

int rv = pool_->RequestSocket(

« no previous file with comments | « net/http/http_network_transaction.cc ('k') | no next file » | no next file with comments »