net/http/http_network_transaction.cc - Issue 155150: CHECK to make sure connection_group is never empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 155150: CHECK to make sure connection_group is never empty. (Closed)

Patch Set: Add comments. Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_transaction.cc

diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc

index c1d0cef1d84ae196c6eaf5e34c491c59f04e74f3..5d4c8dd43ab7bb4bb18e4fcde42fd6301b77f686 100644

--- a/net/http/http_network_transaction.cc

+++ b/net/http/http_network_transaction.cc

@@ -592,7 +592,11 @@ int HttpNetworkTransaction::DoInitConnection() {

if (proxy_mode_ != kHTTPProxy)

connection_group.append(request_->url.GetOrigin().spec());

- DCHECK(!connection_group.empty());

+ // TODO(willchan): Downgrade this back to a DCHECK after closing

+ // http://crbug.com/15374.

+ CHECK(!connection_group.empty()) << "URL: " << request_->url.GetOrigin()

+ << ", Host: " << host

+ << ", Port: " << port;

HostResolver::RequestInfo resolve_info(host, port);

« no previous file with comments | « no previous file | net/socket/client_socket_handle.cc » ('j') | no next file with comments »