X64: Use CmpObjectType macro everywhere, fix problem with sign of instance ty...

X64: Use CmpObjectType macro everywhere, fix problem with sign of instance types.

Committed: http://code.google.com/p/v8/source/detail?r=2374

[Lasse Reichstein, 2009-07-07 09:39:36]

LGTM

http://codereview.chromium.org/155132/diff/1/2
File src/x64/ic-x64.cc (right):

http://codereview.chromium.org/155132/diff/1/2#newcode218
Line 218: __ j(not_equal, &invoke);
Doesn't this do two loads of the instance type byte instead of just one before?

[William Hesse, 2009-07-08 07:53:43]

http://codereview.chromium.org/155132/diff/1/2
File src/x64/ic-x64.cc (right):

http://codereview.chromium.org/155132/diff/1/2#newcode218
Line 218: __ j(not_equal, &invoke);
On 2009/07/07 09:39:36, Lasse Reichstein wrote:
> Doesn't this do two loads of the instance type byte instead of just one
before?

Yes, but only as two identical Operands.  I don't think there is any additional
memory traffic, because there are no writes to it.  So the read buffers and
caches should work.