src/x64/ic-x64.cc - Issue 155132: X64: Use CmpObjectType macro everywhere, fix problem with sign of instance ty...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 155132: X64: Use CmpObjectType macro everywhere, fix problem with sign of instance ty... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/ic-x64.cc

===================================================================

--- src/x64/ic-x64.cc (revision 2367)

+++ src/x64/ic-x64.cc (working copy)

@@ -212,11 +212,9 @@

__ movq(rdx, Operand(rsp, (argc + 1) * kPointerSize)); // receiver

__ testl(rdx, Immediate(kSmiTagMask));

__ j(zero, &invoke);

- __ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset));

- __ movzxbq(rcx, FieldOperand(rcx, Map::kInstanceTypeOffset));

- __ cmpq(rcx, Immediate(static_cast<int8_t>(JS_GLOBAL_OBJECT_TYPE)));

+ __ CmpObjectType(rdx, JS_GLOBAL_OBJECT_TYPE, rcx);

__ j(equal, &global);

- __ cmpq(rcx, Immediate(static_cast<int8_t>(JS_BUILTINS_OBJECT_TYPE)));

+ __ CmpInstanceType(rcx, JS_BUILTINS_OBJECT_TYPE);

__ j(not_equal, &invoke);

Lasse Reichstein 2009/07/07 09:39:36 Doesn't this do two loads of the instance type byt

William Hesse 2009/07/08 07:53:43 Yes, but only as two identical Operands. I don't

// Patch the receiver on the stack.

« no previous file with comments | « src/x64/codegen-x64.cc ('k') | no next file » | no next file with comments »