Issue 155123: Code coverage on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155123: Code coverage on Windows (Closed)

Created:
11 years, 5 months ago by John Grabowski

Modified:
9 years, 5 months ago

Reviewers:
Randall Spangler, bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Beginning of code coverage on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20045

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -31 lines)			Patch
M	build/common.gypi	View		2 chunks	+17 lines, -5 lines	0 comments	Download
M	chrome/chrome.gyp	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	tools/code_coverage/coverage_posix.py	View	1	9 chunks	+153 lines, -23 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

Thanks to Bradley for sharing MSVS secrets. Only base_unittests for now to get something landed.

11 years, 5 months ago (2009-07-07 05:41:42 UTC) #1

Randall Spangler

LGTM on the python. Need Brad to review the gyp. http://codereview.chromium.org/155123/diff/1004/1006 File tools/code_coverage/coverage_posix.py (right): http://codereview.chromium.org/155123/diff/1004/1006#newcode8 ...

11 years, 5 months ago (2009-07-07 16:14:13 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 155123: Code coverage on Windows (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages