Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: build/common.gypi

Issue 155123: Code coverage on Windows (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | tools/code_coverage/coverage_posix.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 19085)
+++ build/common.gypi (working copy)
@@ -66,7 +66,7 @@
'toolkit_views%': 0,
'linux2%': 0,
-
+
'chrome_personalization%': 0,
},
'target_defaults': {
@@ -113,10 +113,22 @@
'-fprofile-arcs' ],
'link_settings': { 'libraries': [ '-lgcov' ] },
}],
- ]},
- # TODO(jrg): options for code coverage on Windows
- ],
- ],
+ # Finally, for Windows, we simply turn on profiling.
+ ['OS=="win"', {
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'Profile': 'true',
+ },
+ 'VCCLCompilerTool': {
+ # /Z7, not /Zi, so coverage is happy
+ 'DebugInformationFormat': '1',
+ 'AdditionalOptions': '/Yd',
+ }
+ }
+ }], # OS==win
+ ], # conditions for coverage
+ }], # coverage!=0
+ ], # conditions for 'target_defaults'
'default_configuration': 'Debug',
'configurations': {
# VCLinkerTool LinkIncremental values below:
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | tools/code_coverage/coverage_posix.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698