Fix: Make DoCanonicalizeIPv6Address safer by changing loop condition and addi...

Fix: Make DoCanonicalizeIPv6Address safer by changing loop condition and adding
a DCHECK

BUG=none
TEST=n/a

[Yuzo, 2009-07-06 05:20:13]

Hi, Brett,

Can you review this?

Yuzo

[Yuzo, 2009-07-06 05:28:14]

Hi, eroman,

Can you review this?

Yuzo

On 2009/07/06 05:20:13, yuzo wrote:
> Hi, Brett,
> 
> Can you review this?
> 
> Yuzo

[eroman, 2009-07-06 20:58:02]

LGTM.

This can't actually be hit though right?

(I remember debating how to write that, and had decided it didn't matter much
either way).

[Yuzo, 2009-07-07 01:45:52]

Thank you for your review.

On 2009/07/06 20:58:02, eroman wrote:
> LGTM.
> 
> This can't actually be hit though right?

You are right.
My change is just to make sure that the assumption holds.

I will submit this patch shortly.

Yuzo

> 
> (I remember debating how to write that, and had decided it didn't matter much
> either way).

[Yuzo, 2009-07-07 02:12:30]

Ah, it seems that I don't have the commit right for this file.

Can you commit this patch when it's convenient to you?

Yuzo


On 2009/07/07 01:45:52, Yuzo wrote:
> Thank you for your review.
> 
> On 2009/07/06 20:58:02, eroman wrote:
> > LGTM.
> > 
> > This can't actually be hit though right?
> 
> You are right.
> My change is just to make sure that the assumption holds.
> 
> I will submit this patch shortly.
> 
> Yuzo
> 
> > 
> > (I remember debating how to write that, and had decided it didn't matter
much
> > either way).

[Yuzo, 2009-07-13 07:48:25]

Eric, Brett,

Can either of you submit this change, if you haven't yet?

Yuzo

[brettw, 2009-07-13 17:15:22]

Checked in as googleurl@108, I did not pull DEPS.

[Yuzo, 2009-07-14 00:56:51]

Thank you!

Yuzo

On Tue, Jul 14, 2009 at 2:15 AM, <brettw@chromium.org> wrote:
> Checked in as googleurl@108, I did not pull DEPS.

> http://codereview.chromium.org/155077