Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 155049: Add RGBColor::create to handle ref counts for RGBColor objects... (Closed)

Created:
11 years, 5 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Add RGBColor::create to handle ref counts for RGBColor objects correctly. Currently, we leak all allocated RGBColor values because we are messing up the refcounting. This is part one of three of fixing http://crbug.com/9514. Part two is landing the corresponding codegenerator change upstream. Part three is making the RGBColor constructor private. TEST=LayoutTests/transitions/shorthand-border-transitions.html BUG=9514 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M webkit/port/bindings/v8/RGBColor.h View 1 chunk +11 lines, -7 lines 0 comments Download
M webkit/port/bindings/v8/RGBColor.cpp View 1 chunk +17 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 5 months ago (2009-07-03 12:05:16 UTC) #1
dglazkov
11 years, 5 months ago (2009-07-03 16:05:37 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698