Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: webkit/port/bindings/v8/RGBColor.h

Issue 155049: Add RGBColor::create to handle ref counts for RGBColor objects... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/port/bindings/v8/RGBColor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/bindings/v8/RGBColor.h
===================================================================
--- webkit/port/bindings/v8/RGBColor.h (revision 19889)
+++ webkit/port/bindings/v8/RGBColor.h (working copy)
@@ -12,15 +12,19 @@
namespace WebCore {
class RGBColor : public RefCounted<RGBColor> {
- public:
- RGBColor(unsigned rgbcolor) : m_rgbcolor(rgbcolor) { }
+public:
+ // TODO(ager): Make constructor private once codegenerator changes
+ // have landed upstream.
+ RGBColor(unsigned rgbcolor) : m_rgbcolor(rgbcolor) { }
- PassRefPtr<CSSPrimitiveValue> red();
- PassRefPtr<CSSPrimitiveValue> green();
- PassRefPtr<CSSPrimitiveValue> blue();
+ static PassRefPtr<RGBColor> create(unsigned rgbcolor);
- private:
- unsigned m_rgbcolor;
+ PassRefPtr<CSSPrimitiveValue> red();
+ PassRefPtr<CSSPrimitiveValue> green();
+ PassRefPtr<CSSPrimitiveValue> blue();
+
+private:
+ unsigned m_rgbcolor;
};
} // namespace WebCore
« no previous file with comments | « no previous file | webkit/port/bindings/v8/RGBColor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698