Issue 1549047: Mac: Generate valid <keygen> data if challenge string is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1549047: Mac: Generate valid <keygen> data if challenge string is empty (Closed)

Created:
10 years, 8 months ago by Jens Alfke

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, John Grabowski, cbentzel+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Mac: Generate valid <keygen> data if challenge string is empty This works around an apparent bug in Apple's ASN.1 encoder. BUG=41679 TEST=Manual testing with comodo.com or a local test site Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44980

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	net/base/keygen_handler_mac.cc	View		2 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jens Alfke

*ping* I'd like to see if I can get this merged into the M5 branch, ...

10 years, 8 months ago (2010-04-19 16:16:21 UTC) #2

wtc

10 years, 8 months ago (2010-04-19 22:43:45 UTC) #3

LGTM.  Sorry about the delay.  I took last Friday off.

http://codereview.chromium.org/1549047/diff/1/2
File net/base/keygen_handler_mac.cc (right):

http://codereview.chromium.org/1549047/diff/1/2#newcode28
net/base/keygen_handler_mac.cc:28: const SecAsn1Template kIA5StringTemplate[] =
{
Nit: add a comment to explain why we can't use
kSecAsn1IA5StringTemplate from the Security Framework.

Expand Messages | Collapse Messages