Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: net/base/keygen_handler_mac.cc

Issue 1549047: Mac: Generate valid <keygen> data if challenge string is empty (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/keygen_handler_mac.cc
diff --git a/net/base/keygen_handler_mac.cc b/net/base/keygen_handler_mac.cc
index 35e47144cb79c12b71e08091e7c410add6bd2c2f..4882f1da0538b282d8905e67317c7dd78e522d04 100644
--- a/net/base/keygen_handler_mac.cc
+++ b/net/base/keygen_handler_mac.cc
@@ -25,6 +25,10 @@ struct PublicKeyAndChallenge {
CSSM_DATA challenge_string;
};
+const SecAsn1Template kIA5StringTemplate[] = {
wtc 2010/04/19 22:43:45 Nit: add a comment to explain why we can't use kSe
+ { SEC_ASN1_IA5_STRING, 0, NULL, sizeof(CSSM_DATA) }
+};
+
static const SecAsn1Template kPublicKeyAndChallengeTemplate[] = {
{
SEC_ASN1_SEQUENCE,
@@ -40,7 +44,7 @@ static const SecAsn1Template kPublicKeyAndChallengeTemplate[] = {
{
SEC_ASN1_INLINE,
offsetof(PublicKeyAndChallenge, challenge_string),
- kSecAsn1IA5StringTemplate
+ kIA5StringTemplate
},
{
0
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698