Issue 1549020: Add a scoped notifier for pref dictionaries / lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1549020: Add a scoped notifier for pref dictionaries / lists. (Closed)

Created:
10 years, 8 months ago by chron_chromium.org

Modified:
9 years, 7 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org

Visibility:
Public.

Description

Add a scoped notifier for pref dictionaries / lists. Other options included subclassing the pref value types, making the firenotifications public, or just friend classing. Since values can contain other values, such as dictionary within dictionary, it didn't seem like a good idea to subclass. We might want to consider combining the scoped lookup with the GetMutableList call at some point, but some callers keep a long reference so that might be a bad idea. BUG=38557 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43678

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -7 lines)			Patch
M	chrome/browser/cocoa/preferences_window_controller.mm	View	2	1 chunk	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/pref_service.h	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
A	chrome/browser/scoped_pref_update.h	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/scoped_pref_update.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/session_startup_pref.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/views/options/general_page_view.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

You'll need to comment out the receiver of this notification in preferences_window_controller.mm line 946, or ...

10 years, 8 months ago (2010-04-05 20:45:23 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 1549020: Add a scoped notifier for pref dictionaries / lists. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix EOL whitespace #

Patch Set 3 : Fix props. #

Messages