Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/cocoa/preferences_window_controller.mm

Issue 1549020: Add a scoped notifier for pref dictionaries / lists. (Closed)
Patch Set: Fix props. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/pref_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/preferences_window_controller.mm
diff --git a/chrome/browser/cocoa/preferences_window_controller.mm b/chrome/browser/cocoa/preferences_window_controller.mm
index 3503acc9b7a0fabc8f654fe975b667207196a9af..cfe80bf9787c8052d5eb85a41a5274cff195bd80 100644
--- a/chrome/browser/cocoa/preferences_window_controller.mm
+++ b/chrome/browser/cocoa/preferences_window_controller.mm
@@ -949,11 +949,14 @@ void PersonalDataManagerObserver::ShowAutoFillDialog(
// never match. Once support for broadcasting such updates is
// added, this will automagically start to work, and this comment
// can be removed.
- if (*prefName == prefs::kURLsToRestoreOnStartup) {
- const SessionStartupPref startupPref =
- SessionStartupPref::GetStartupPref(prefs_);
- [customPagesSource_ setURLs:startupPref.urls];
- }
+ // TODO(chron): We comment out this block right now because we have put in
+ // broadcast for notifications, but there's some workaround
+ // currently present that causes an infinite loop.
+ // if (*prefName == prefs::kURLsToRestoreOnStartup) {
+ // const SessionStartupPref startupPref =
+ // SessionStartupPref::GetStartupPref(prefs_);
+ // [customPagesSource_ setURLs:startupPref.urls];
+ // }
if (*prefName == prefs::kHomePageIsNewTabPage) {
NSInteger useNewTabPage = newTabPageIsHomePage_.GetValue() ? 0 : 1;
« no previous file with comments | « no previous file | chrome/browser/pref_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698